Skip to content

Comments

S32K344 Basic porting : FINSH#9544

Draft
ppppppsssss wants to merge 2 commits intoRT-Thread:masterfrom
ppppppsssss:pillar
Draft

S32K344 Basic porting : FINSH#9544
ppppppsssss wants to merge 2 commits intoRT-Thread:masterfrom
ppppppsssss:pillar

Conversation

@ppppppsssss
Copy link

@ppppppsssss ppppppsssss commented Oct 19, 2024

拉取/合并请求描述：(PR description)

适配S32K344的基础工程，对LPUART采用寄存器控制，实现FINSH的移植，同时每两秒打印hello验证调度和延时的正确

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@ppppppsssss ppppppsssss requested a review from Rbb666 as a code owner October 19, 2024 10:29
@github-actions github-actions bot added BSP: NXP Code related with NXP BSP labels Oct 19, 2024
@BernardXiong
Copy link
Member

BernardXiong commented Oct 19, 2024

bsp/nxp/S32K3/S32K344, please rename as:

bsp/nxp/s32/s32k344_core

@mysterywolf
Copy link
Member

mysterywolf commented Oct 19, 2024

我建议命名成 bsp/nxp/s32/s32k344-core 文件夹名称可以用中划线

@supperthomas
Copy link
Member

supperthomas commented Oct 20, 2024

ci加一下。在.github/workflow/bsp_building.yml

@ppppppsssss
Copy link
Author

ppppppsssss commented Oct 21, 2024

好的，更改了
同时移除了nxp的库，改为使用者自行手动添加，添加方法在 readme 中给出

@ppppppsssss ppppppsssss force-pushed the pillar branch 2 times, most recently from 4bdca1c to a7fa3a7 Compare October 21, 2024 05:50
@Rbb666
Copy link
Member

Rbb666 commented Oct 21, 2024

好的，更改了 同时移除了nxp的库，改为使用者自行手动添加，添加方法在 readme 中给出

麻烦把此ci加一下。在.github/workflow/bsp_building.yml中，添加此BSP

@supperthomas
Copy link
Member

supperthomas commented Oct 25, 2024

ci添加参考：

https://club.rt-thread.org/ask/article/62273896dee18b09.html
image

@Rbb666
Copy link
Member

Rbb666 commented Nov 20, 2024

@PillarShi CI方便加下吗？

@supperthomas supperthomas added the BSP: new bsp board New added bsp, need sync action label Nov 20, 2024
@supperthomas supperthomas self-requested a review as a code owner November 20, 2024 03:20
@github-actions github-actions bot added the action github action yml imporve label Nov 20, 2024
@supperthomas
Copy link
Member

supperthomas commented Nov 20, 2024

C build/board/board.o

56 scons: *** [build/applications/main.o] Error 1

57 In file included from board/board.c:11:

58 board/board.h:16:10: fatal error: S32K344.h: No such file or directory

59 16 | #include "S32K344.h"

60 | ^~~~~~~~~~~

61 compilation terminated.

62 scons: *** [build/board/board.o] Error 1

@supperthomas
Copy link
Member

supperthomas commented Nov 20, 2024

好的，更改了
同时移除了nxp的库，改为使用者自行手动添加，添加方法在 readme 中给出

为啥要移除？

@supperthomas
Copy link
Member

supperthomas commented Nov 20, 2024

好的，更改了
同时移除了nxp的库，改为使用者自行手动添加，添加方法在 readme 中给出

为啥要移除？

可以只放编译需要的文件

@ppppppsssss
Copy link
Author

ppppppsssss commented Nov 21, 2024 •
edited
Loading

NXP这里的生成的代码是有许可证问题，考虑到这个是不是最好不要放上来？那么ci就只能做检查，不能编译

同时目前这个版本可能要再改动一下，做到更好的适配

@Rbb666 Rbb666 marked this pull request as draft November 21, 2024 15:39
@supperthomas
Copy link
Member

supperthomas commented Nov 22, 2024

NXP这里的生成的代码是有许可证问题，考虑到这个是不是最好不要放上来？那么ci就只能做检查，不能编译

同时目前这个版本可能要再改动一下，做到更好的适配

可以考虑制作软件包的方式，参考nrf5x/nrf52840

@Rbb666
Copy link
Member

Rbb666 commented May 21, 2025

请问作者这个 pr 还有在推进吗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rbb666 Rbb666 Awaiting requested review from Rbb666 Rbb666 is a code owner

@supperthomas supperthomas Awaiting requested review from supperthomas supperthomas is a code owner

@kurisaW kurisaW Awaiting requested review from kurisaW kurisaW will be requested when the pull request is marked ready for review kurisaW is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

action github action yml imporve BSP: new bsp board New added bsp, need sync action BSP: NXP Code related with NXP BSP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ppppppsssss @BernardXiong @mysterywolf @supperthomas @Rbb666